Code cleanup.

Of note:
* io.save_all_files() does not visit each buffer to save anymore. An unintended
  side-effect was checking for outside modification (but only if the file itself
  was modified), so outside changes will always be saved over now.
* The menu clicked handler uses assert_type(), so the 'Unknown command'
  localization is no longer needed.
* When printing to a new buffer type would split the view, use an existing split
  view when possible.
* Prefer 'goto continue' construct in loops over nested 'if's.
* Fixed clearing of ui.find.replace_entry_text on reset in the GUI version.
* Fixed lack of statusbar updating when setting options like buffer EOL mode,
  indentation, and encoding.
* Renamed internal new_snippet() to new() and put it in the snippet metatable.

9 files changed, 0 insertions, 27 deletions

diff --git a/core/locales/locale.ar.conf b/core/locales/locale.ar.conf
index 953d3d38..e894445e 100644
--- a/core/locales/locale.ar.conf
+++ b/core/locales/locale.ar.conf
@@ -336,9 +336,6 @@ Help = م_ساعدة
 Show Manual = عرض الد_ليل
 Show LuaDoc = عرض و_ثائق لُوَ
 About = ع_ن
-# The error message displayed when activating a menu item associated with an
-# unknown command.
-Unknown command: = أمر مجهول:
 # The text displayed in the dialog for running an arbitrary menu command. Any
 # key binding associated with commands are also shown.
 Run Command = شغِّل الأمر
diff --git a/core/locales/locale.de.conf b/core/locales/locale.de.conf
index 22d46b5c..d73ca229 100644
--- a/core/locales/locale.de.conf
+++ b/core/locales/locale.de.conf
@@ -336,9 +336,6 @@ Help = _Hilfe
 Show Manual = Handbuch anzeigen
 Show LuaDoc = LuaDoc anzeigen
 About = _Über Textadept
-# The error message displayed when activating a menu item associated with an
-# unknown command.
-Unknown command: = Unbekannter Befehl:
 # The text displayed in the dialog for running an arbitrary menu command. Any
 # key binding associated with commands are also shown.
 Run Command = Befehl ausführen
diff --git a/core/locales/locale.es.conf b/core/locales/locale.es.conf
index 354a33fc..273b90ca 100644
--- a/core/locales/locale.es.conf
+++ b/core/locales/locale.es.conf
@@ -336,9 +336,6 @@ Help = A_yuda
 Show Manual = Mostrar _manual
 Show LuaDoc = Mostrar _LuaDoc
 About = Acerca _de
-# The error message displayed when activating a menu item associated with an
-# unknown command.
-Unknown command: = Comando desconocido:
 # The text displayed in the dialog for running an arbitrary menu command. Any
 # key binding associated with commands are also shown.
 Run Command = Ejecutar comando
diff --git a/core/locales/locale.fr.conf b/core/locales/locale.fr.conf
index b2fff92d..f3afccfa 100644
--- a/core/locales/locale.fr.conf
+++ b/core/locales/locale.fr.conf
@@ -337,9 +337,6 @@ Help = Aid_e
 Show Manual = Voir _manuel
 Show LuaDoc = Voir la documentation sur l’_API
 About = À _propos
-# The error message displayed when activating a menu item associated with an
-# unknown command.
-Unknown command: = Commande inconnue:
 # The text displayed in the dialog for running an arbitrary menu command. Any
 # key binding associated with commands are also shown.
 Run Command = Lancer une commande
diff --git a/core/locales/locale.it.conf b/core/locales/locale.it.conf
index 91d4958a..d9c508a1 100644
--- a/core/locales/locale.it.conf
+++ b/core/locales/locale.it.conf
@@ -336,9 +336,6 @@ Help = _Aiuto
 Show Manual = _Manuale
 Show LuaDoc = _Documentazione sull’API
 About = _Informazioni
-# The error message displayed when activating a menu item associated with an
-# unknown command.
-Unknown command: = Comando sconosciuto:
 # The text displayed in the dialog for running an arbitrary menu command. Any
 # key binding associated with commands are also shown.
 Run Command = Scegli un comando
diff --git a/core/locales/locale.pl.conf b/core/locales/locale.pl.conf
index bbe34282..a33b1d69 100644
--- a/core/locales/locale.pl.conf
+++ b/core/locales/locale.pl.conf
@@ -337,9 +337,6 @@ Help = P_omoc
 Show Manual = Po_dręcznik użytkownika...
 Show LuaDoc = _LuaDoc...
 About = _O programie...
-# The error message displayed when activating a menu item associated with an
-# unknown command.
-Unknown command: = Nieznane polecenie:
 # The text displayed in the dialog for running an arbitrary menu command. Any
 # key binding associated with commands are also shown.
 Run Command = Wykonaj polecenie
diff --git a/core/locales/locale.ru.conf b/core/locales/locale.ru.conf
index 3bfb7198..476d0f63 100644
--- a/core/locales/locale.ru.conf
+++ b/core/locales/locale.ru.conf
@@ -336,9 +336,6 @@ Help = _Справка
 Show Manual = Показать _руководство
 Show LuaDoc = Показать документацию по _lua
 About = _О программе
-# The error message displayed when activating a menu item associated with an
-# unknown command.
-Unknown command: = Неизвестная команда:
 # The text displayed in the dialog for running an arbitrary menu command. Any
 # key binding associated with commands are also shown.
 Run Command = Выполнить команду
diff --git a/core/locales/locale.sv.conf b/core/locales/locale.sv.conf
index d56d2456..f6f01d17 100644
--- a/core/locales/locale.sv.conf
+++ b/core/locales/locale.sv.conf
@@ -336,9 +336,6 @@ Help = _Hjälp
 Show Manual = _Manual
 Show LuaDoc = _LuaDoc
 About = _Om
-# The error message displayed when activating a menu item associated with an
-# unknown command.
-Unknown command: = Okänt kommando:
 # The text displayed in the dialog for running an arbitrary menu command. Any
 # key binding associated with commands are also shown.
 Run Command = Kör kommando
diff --git a/core/locales/locale.zh.conf b/core/locales/locale.zh.conf
index dbce6e55..54476596 100644
--- a/core/locales/locale.zh.conf
+++ b/core/locales/locale.zh.conf
@@ -336,9 +336,6 @@ Help = 帮助(_H)
 Show Manual = 打开手册(_M)
 Show LuaDoc = 打开_LuaDoc
 About = 关于(_A)
-# The error message displayed when activating a menu item associated with an
-# unknown command.
-Unknown command: = 未知命令:
 # The text displayed in the dialog for running an arbitrary menu command. Any
 # key binding associated with commands are also shown.
 Run Command = 运行命令